summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMukesh Ojha <quic_mojha@quicinc.com>2024-02-19 22:09:54 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-03-07 22:05:09 +0000
commit1fe6e4f0b0c47e70735066e889f97c3c6e1e79b2 (patch)
tree4014915373a758b80587bcc4f3d557f1608977de
parenta54c1d1b859a57a99d5cbdce37ac754cbdd9344a (diff)
downloadlinux-1fe6e4f0b0c47e70735066e889f97c3c6e1e79b2.tar.gz
linux-1fe6e4f0b0c47e70735066e889f97c3c6e1e79b2.tar.bz2
linux-1fe6e4f0b0c47e70735066e889f97c3c6e1e79b2.zip
firmware_loader: Suppress warning on FW_OPT_NO_WARN flag
Some of the warnings are still being printed even if FW_OPT_NO_WARN is passed for some of the function e.g., firmware_request_nowarn(). Fix it by adding a check for FW_OPT_NO_WARN before printing the warning. Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org> Link: https://lore.kernel.org/r/20240219163954.7719-1-quic_mojha@quicinc.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/base/firmware_loader/main.c16
1 files changed, 10 insertions, 6 deletions
diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
index ea28102d421e..da8ca01d011c 100644
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -551,12 +551,16 @@ fw_get_filesystem_firmware(struct device *device, struct fw_priv *fw_priv,
file_size_ptr,
READING_FIRMWARE);
if (rc < 0) {
- if (rc != -ENOENT)
- dev_warn(device, "loading %s failed with error %d\n",
- path, rc);
- else
- dev_dbg(device, "loading %s failed for no such file or directory.\n",
- path);
+ if (!(fw_priv->opt_flags & FW_OPT_NO_WARN)) {
+ if (rc != -ENOENT)
+ dev_warn(device,
+ "loading %s failed with error %d\n",
+ path, rc);
+ else
+ dev_dbg(device,
+ "loading %s failed for no such file or directory.\n",
+ path);
+ }
continue;
}
size = rc;