diff options
| author | Zev Weiss <zev@bewilderbeest.net> | 2021-11-10 18:53:38 -0800 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2021-11-14 16:57:16 -0800 |
| commit | 214f525255069a55b4664842c68bc15b2ee049f0 (patch) | |
| tree | e5f371e89054a14730b12bf5d4416d667b23356f | |
| parent | dbd3e6eaf3d813939b28e8a66e29d81cdc836445 (diff) | |
| download | linux-214f525255069a55b4664842c68bc15b2ee049f0.tar.gz linux-214f525255069a55b4664842c68bc15b2ee049f0.tar.bz2 linux-214f525255069a55b4664842c68bc15b2ee049f0.zip | |
hwmon: (nct6775) mask out bank number in nct6775_wmi_read_value()
The first call to nct6775_asuswmi_read() in nct6775_wmi_read_value()
had been passing the full bank+register number instead of just the
lower 8 bits. It didn't end up actually causing problems because the
second argument of that function is a u8 anyway, but it seems
preferable to be explicit about it at the call site (and consistent
with the rest of the code).
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Fixes: 3fbbfc27f955 ("hwmon: (nct6775) Support access via Asus WMI")
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20211111025339.27520-1-zev@bewilderbeest.net
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/nct6775.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c index 93dca471972e..57ce8633a725 100644 --- a/drivers/hwmon/nct6775.c +++ b/drivers/hwmon/nct6775.c @@ -1527,7 +1527,7 @@ static u16 nct6775_wmi_read_value(struct nct6775_data *data, u16 reg) nct6775_wmi_set_bank(data, reg); - err = nct6775_asuswmi_read(data->bank, reg, &tmp); + err = nct6775_asuswmi_read(data->bank, reg & 0xff, &tmp); if (err) return 0; |