summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoel Stanley <joel@jms.id.au>2023-01-20 09:48:56 +1030
committerLinus Walleij <linus.walleij@linaro.org>2023-01-27 13:32:44 +0100
commit287a344a11f1ebd31055cf9b22c88d7005f108d7 (patch)
treea490705ad22d2fb245b29b3e755e75bc64955069
parent5754a1c98b18009cb3030dc391aa37b77428a0bd (diff)
downloadlinux-287a344a11f1ebd31055cf9b22c88d7005f108d7.tar.gz
linux-287a344a11f1ebd31055cf9b22c88d7005f108d7.tar.bz2
linux-287a344a11f1ebd31055cf9b22c88d7005f108d7.zip
pinctrl: aspeed: Fix confusing types in return value
The function signature is int, but we return a bool. Instead return a negative errno as the kerneldoc suggests. Fixes: 4d3d0e4272d8 ("pinctrl: Add core support for Aspeed SoCs") Signed-off-by: Joel Stanley <joel@jms.id.au> Reviewed-by: Andrew Jeffery <andrew@aj.id.au> Link: https://lore.kernel.org/r/20230119231856.52014-1-joel@jms.id.au Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r--drivers/pinctrl/aspeed/pinctrl-aspeed.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed.c b/drivers/pinctrl/aspeed/pinctrl-aspeed.c
index 3945612900e6..b5ca4501a605 100644
--- a/drivers/pinctrl/aspeed/pinctrl-aspeed.c
+++ b/drivers/pinctrl/aspeed/pinctrl-aspeed.c
@@ -114,7 +114,7 @@ static int aspeed_disable_sig(struct aspeed_pinmux_data *ctx,
int ret = 0;
if (!exprs)
- return true;
+ return -EINVAL;
while (*exprs && !ret) {
ret = aspeed_sig_expr_disable(ctx, *exprs);