summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYang Li <yang.lee@linux.alibaba.com>2021-06-04 18:08:27 +0800
committerSaeed Mahameed <saeedm@nvidia.com>2021-06-09 17:20:02 -0700
commit2bf8d2ae3480da06e64dad3b326ebd2e40c0be86 (patch)
tree4dcb8d04be7abd1348902af093b21fbc90326eaf
parent13c62f5371e3eb4fc3400cfa26e64ca75f888008 (diff)
downloadlinux-2bf8d2ae3480da06e64dad3b326ebd2e40c0be86.tar.gz
linux-2bf8d2ae3480da06e64dad3b326ebd2e40c0be86.tar.bz2
linux-2bf8d2ae3480da06e64dad3b326ebd2e40c0be86.zip
net/mlx5e: Fix an error code in mlx5e_arfs_create_tables()
When the code execute 'if (!priv->fs.arfs->wq)', the value of err is 0. So, we use -ENOMEM to indicate that the function create_singlethread_workqueue() return NULL. Clean up smatch warning: drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c:373 mlx5e_arfs_create_tables() warn: missing error code 'err'. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Fixes: f6755b80d693 ("net/mlx5e: Dynamic alloc arfs table for netdev when needed") Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
index 5cd466ec6492..25403af32859 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
@@ -356,7 +356,7 @@ err:
int mlx5e_arfs_create_tables(struct mlx5e_priv *priv)
{
- int err = 0;
+ int err = -ENOMEM;
int i;
if (!(priv->netdev->hw_features & NETIF_F_NTUPLE))