diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2008-11-30 01:33:57 -0500 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2008-12-04 04:22:59 -0500 |
| commit | 2cbed8906fd1f3c6cc17cdf8aac1bfad2da7960c (patch) | |
| tree | 47c3761f6341054ea14523743fbbd11a8be9b6eb | |
| parent | fc9161e54d0dbf799beff9692ea1cc6237162b85 (diff) | |
| download | linux-2cbed8906fd1f3c6cc17cdf8aac1bfad2da7960c.tar.gz linux-2cbed8906fd1f3c6cc17cdf8aac1bfad2da7960c.tar.bz2 linux-2cbed8906fd1f3c6cc17cdf8aac1bfad2da7960c.zip | |
[PATCH] fix bogus argument of blkdev_put() in pktcdvd
final close of ->bdev should match the initial open, i.e.
get FMODE_READ | FMODE_NDELAY; FMODE_READ|FMODE_WRITE has
been a braino.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
| -rw-r--r-- | drivers/block/pktcdvd.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index f20bf359b84f..edda7b6b077b 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -2790,7 +2790,7 @@ static int pkt_new_dev(struct pktcdvd_device *pd, dev_t dev) return 0; out_mem: - blkdev_put(bdev, FMODE_READ|FMODE_WRITE); + blkdev_put(bdev, FMODE_READ | FMODE_NDELAY); /* This is safe: open() is still holding a reference. */ module_put(THIS_MODULE); return ret; @@ -2975,7 +2975,7 @@ static int pkt_remove_dev(dev_t pkt_dev) pkt_debugfs_dev_remove(pd); pkt_sysfs_dev_remove(pd); - blkdev_put(pd->bdev, FMODE_READ|FMODE_WRITE); + blkdev_put(pd->bdev, FMODE_READ | FMODE_NDELAY); remove_proc_entry(pd->name, pkt_proc); DPRINTK(DRIVER_NAME": writer %s unmapped\n", pd->name); |