diff options
| author | Darrick J. Wong <darrick.wong@oracle.com> | 2020-03-11 10:37:57 -0700 |
|---|---|---|
| committer | Darrick J. Wong <darrick.wong@oracle.com> | 2020-03-12 07:58:13 -0700 |
| commit | 2e107cf869eecc770e3f630060bb4e5f547d0fd8 (patch) | |
| tree | 19c8185b4085b62004e86ba2060701ef38417ca0 | |
| parent | 1b2c1a63b678d63e9c98314d44413f5af79c9c80 (diff) | |
| download | linux-2e107cf869eecc770e3f630060bb4e5f547d0fd8.tar.gz linux-2e107cf869eecc770e3f630060bb4e5f547d0fd8.tar.bz2 linux-2e107cf869eecc770e3f630060bb4e5f547d0fd8.zip | |
xfs: mark dir corrupt when lookup-by-hash fails
In xchk_dir_actor, we attempt to validate the directory hash structures
by performing a directory entry lookup by (hashed) name. If the lookup
returns ENOENT, that means that the hash information is corrupt. The
_process_error functions don't catch this, so we have to add that
explicitly.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
| -rw-r--r-- | fs/xfs/scrub/dir.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/xfs/scrub/dir.c b/fs/xfs/scrub/dir.c index 266da4e4bde6..ef7cc8e101ab 100644 --- a/fs/xfs/scrub/dir.c +++ b/fs/xfs/scrub/dir.c @@ -155,6 +155,9 @@ xchk_dir_actor( xname.type = XFS_DIR3_FT_UNKNOWN; error = xfs_dir_lookup(sdc->sc->tp, ip, &xname, &lookup_ino, NULL); + /* ENOENT means the hash lookup failed and the dir is corrupt */ + if (error == -ENOENT) + error = -EFSCORRUPTED; if (!xchk_fblock_process_error(sdc->sc, XFS_DATA_FORK, offset, &error)) goto out; |