diff options
| author | Colin Ian King <colin.king@canonical.com> | 2021-03-27 23:27:44 +0000 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2021-04-01 09:53:14 +0200 |
| commit | 315e2811f58b807e6e76b7385e3d7b970f4562d2 (patch) | |
| tree | 97986d1783a203f3bcff6bc6f172acdeeb84db3f | |
| parent | 764de1059b97ca1fe8fe023bb10e736772945c87 (diff) | |
| download | linux-315e2811f58b807e6e76b7385e3d7b970f4562d2.tar.gz linux-315e2811f58b807e6e76b7385e3d7b970f4562d2.tar.bz2 linux-315e2811f58b807e6e76b7385e3d7b970f4562d2.zip | |
USB: serial: iuu_phoenix: remove redundant variable 'error'
The variable error is initialized to 0 and is set to 1 this
value is never read as it is on an immediate return path. The
only read of error is to check it is 0 and this check is always
true at that point of the code. The variable is redundant and
can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
| -rw-r--r-- | drivers/usb/serial/iuu_phoenix.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c index 093afd67a664..19753611e7b0 100644 --- a/drivers/usb/serial/iuu_phoenix.c +++ b/drivers/usb/serial/iuu_phoenix.c @@ -643,7 +643,6 @@ static void iuu_uart_read_callback(struct urb *urb) struct iuu_private *priv = usb_get_serial_port_data(port); unsigned long flags; int status = urb->status; - int error = 0; int len = 0; unsigned char *data = urb->transfer_buffer; priv->poll++; @@ -660,12 +659,11 @@ static void iuu_uart_read_callback(struct urb *urb) if (urb->actual_length > 1) { dev_dbg(&port->dev, "%s - urb->actual_length = %i\n", __func__, urb->actual_length); - error = 1; return; } /* if len > 0 call readbuf */ - if (len > 0 && error == 0) { + if (len > 0) { dev_dbg(&port->dev, "%s - call read buf - len to read is %i\n", __func__, len); status = iuu_read_buf(port, len); |