diff options
| author | Markus Schneider-Pargmann <msp@baylibre.com> | 2024-08-07 16:12:25 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-08-14 08:22:49 +0200 |
| commit | 35e648a16018b747897be2ccc3ce95ff23237bb5 (patch) | |
| tree | 0cc90eb600b008d8c5e2a6e9cf9e6cb95e42e654 | |
| parent | 704c2c361e1f405dcf676217498a7c24b64190cb (diff) | |
| download | linux-35e648a16018b747897be2ccc3ce95ff23237bb5.tar.gz linux-35e648a16018b747897be2ccc3ce95ff23237bb5.tar.bz2 linux-35e648a16018b747897be2ccc3ce95ff23237bb5.zip | |
serial: 8250: omap: Cleanup on error in request_irq
If devm_request_irq fails, the code does not cleanup many things that
were setup before. Instead of directly returning ret we should jump to
err.
Fixes: fef4f600319e ("serial: 8250: omap: Fix life cycle issues for interrupt handlers")
Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
Link: https://lore.kernel.org/r/20240807141227.1093006-4-msp@baylibre.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/tty/serial/8250/8250_omap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c index 02d4f3073696..01d430de9c64 100644 --- a/drivers/tty/serial/8250/8250_omap.c +++ b/drivers/tty/serial/8250/8250_omap.c @@ -1587,7 +1587,7 @@ static int omap8250_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, up.port.irq, omap8250_irq, 0, dev_name(&pdev->dev), priv); if (ret < 0) - return ret; + goto err; priv->wakeirq = irq_of_parse_and_map(np, 1); |