diff options
| author | Ricardo Ribalda <ribalda@chromium.org> | 2024-05-27 21:08:58 +0000 |
|---|---|---|
| committer | Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2024-05-31 13:51:16 +0200 |
| commit | 364ae46413f67f97e4611b050d7d53079dbb9dba (patch) | |
| tree | 59b23becf768fe65bac6dfb2e214bef054848d8f | |
| parent | b657179a11d9834df16b3bc2015f2931d20de528 (diff) | |
| download | linux-364ae46413f67f97e4611b050d7d53079dbb9dba.tar.gz linux-364ae46413f67f97e4611b050d7d53079dbb9dba.tar.bz2 linux-364ae46413f67f97e4611b050d7d53079dbb9dba.zip | |
media: siano: Use flex arrays for sms_firmware
Replace old style single array member, with flex array.
The struct is allocated, but it seems like there was an over allocation
error:
fw_buf = kmalloc(ALIGN(fw->size + sizeof(struct sms_firmware),
SMS_ALLOC_ALIGNMENT), GFP_KERNEL | coredev->gfp_buf_flags);
This change fixes this cocci warning:
drivers/media/common/siano/smscoreapi.h:669:6-13: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
| -rw-r--r-- | drivers/media/common/siano/smscoreapi.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/common/siano/smscoreapi.h b/drivers/media/common/siano/smscoreapi.h index bc61bc8b9ea9..82d9f8a64d99 100644 --- a/drivers/media/common/siano/smscoreapi.h +++ b/drivers/media/common/siano/smscoreapi.h @@ -666,7 +666,7 @@ struct sms_firmware { u32 check_sum; u32 length; u32 start_address; - u8 payload[1]; + u8 payload[]; }; /* statistics information returned as response for |