diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2020-02-17 17:40:50 +0300 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2020-02-24 21:59:45 +0530 |
| commit | 36d5d22090d13fd3a7a8c9663a711cbe6970aac8 (patch) | |
| tree | 0723bdf23cc4bc6074a711a2a4834bd0c5770c77 | |
| parent | 2d0b1919457ad78036f24169968cadc6f55d37ec (diff) | |
| download | linux-36d5d22090d13fd3a7a8c9663a711cbe6970aac8.tar.gz linux-36d5d22090d13fd3a7a8c9663a711cbe6970aac8.tar.bz2 linux-36d5d22090d13fd3a7a8c9663a711cbe6970aac8.zip | |
dmaengine: coh901318: Fix a double lock bug in dma_tc_handle()
The caller is already holding the lock so this will deadlock.
Fixes: 0b58828c923e ("DMAENGINE: COH 901 318 remove irq counting")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200217144050.3i4ymbytogod4ijn@kili.mountain
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/dma/coh901318.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/dma/coh901318.c b/drivers/dma/coh901318.c index e51d836afcc7..1092d4ce723e 100644 --- a/drivers/dma/coh901318.c +++ b/drivers/dma/coh901318.c @@ -1947,8 +1947,6 @@ static void dma_tc_handle(struct coh901318_chan *cohc) return; } - spin_lock(&cohc->lock); - /* * When we reach this point, at least one queue item * should have been moved over from cohc->queue to @@ -1969,8 +1967,6 @@ static void dma_tc_handle(struct coh901318_chan *cohc) if (coh901318_queue_start(cohc) == NULL) cohc->busy = 0; - spin_unlock(&cohc->lock); - /* * This tasklet will remove items from cohc->active * and thus terminates them. |