diff options
| author | Necip Fazil Yildiran <fazilyildiran@gmail.com> | 2020-11-03 00:34:01 +0300 |
|---|---|---|
| committer | Thomas Bogendoerfer <tsbogend@alpha.franken.de> | 2020-11-12 23:21:55 +0100 |
| commit | 3a5fe2fb9635c43359c9729352f45044f3c8df6b (patch) | |
| tree | 0b2f7f848184bbc2ae817ba92df77bac76463ab3 | |
| parent | 09a48cbcd7af9203296938044f1100bb113ce01a (diff) | |
| download | linux-3a5fe2fb9635c43359c9729352f45044f3c8df6b.tar.gz linux-3a5fe2fb9635c43359c9729352f45044f3c8df6b.tar.bz2 linux-3a5fe2fb9635c43359c9729352f45044f3c8df6b.zip | |
MIPS: BCM47XX: fix kconfig dependency bug for BCM47XX_BCMA
When BCM47XX_BCMA is enabled and BCMA_DRIVER_PCI is disabled, it results
in the following Kbuild warning:
WARNING: unmet direct dependencies detected for BCMA_DRIVER_PCI_HOSTMODE
Depends on [n]: MIPS [=y] && BCMA_DRIVER_PCI [=n] && PCI_DRIVERS_LEGACY [=y] && BCMA [=y]=y
Selected by [y]:
- BCM47XX_BCMA [=y] && BCM47XX [=y] && PCI [=y]
The reason is that BCM47XX_BCMA selects BCMA_DRIVER_PCI_HOSTMODE without
depending on or selecting BCMA_DRIVER_PCI while BCMA_DRIVER_PCI_HOSTMODE
depends on BCMA_DRIVER_PCI. This can also fail building the kernel.
Honor the kconfig dependency to remove unmet direct dependency warnings
and avoid any potential build failures.
Fixes: c1d1c5d4213e ("bcm47xx: add support for bcma bus")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=209879
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
| -rw-r--r-- | arch/mips/bcm47xx/Kconfig | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/mips/bcm47xx/Kconfig b/arch/mips/bcm47xx/Kconfig index 40876654423c..13d315ee676b 100644 --- a/arch/mips/bcm47xx/Kconfig +++ b/arch/mips/bcm47xx/Kconfig @@ -28,6 +28,7 @@ config BCM47XX_BCMA select BCMA select BCMA_HOST_SOC select BCMA_DRIVER_MIPS + select BCMA_DRIVER_PCI if PCI select BCMA_DRIVER_PCI_HOSTMODE if PCI select BCMA_DRIVER_GPIO default y |