diff options
| author | Daniel Scally <dan.scally@ideasonboard.com> | 2024-01-18 11:29:59 +0000 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2024-01-22 16:04:13 +0530 |
| commit | 4728e3fe2ff1b02b84ddab876d8af5eeb74eee18 (patch) | |
| tree | 77a3799aa593b4412cf6307d27412789845a18eb | |
| parent | 6613476e225e090cc9aad49be7fa504e290dd33d (diff) | |
| download | linux-4728e3fe2ff1b02b84ddab876d8af5eeb74eee18.tar.gz linux-4728e3fe2ff1b02b84ddab876d8af5eeb74eee18.tar.bz2 linux-4728e3fe2ff1b02b84ddab876d8af5eeb74eee18.zip | |
dmaengine: pl330: Clear callback_result for re-used descs
The pl330 driver re-uses DMA descriptors rather than reallocating
them each time. At present, upon re-use the .callback member is
cleared, but .callback result is not. This causes problems where a
consuming driver sets the .callback_result for some submissions but
not for others, as eventually the function is invoked erronously.
Clear .callback_result along with .callback
Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
Link: https://lore.kernel.org/r/20240118112959.1027471-1-dan.scally@ideasonboard.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/dma/pl330.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index c29744bfdf2c..5f6d7f1e095f 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -2588,6 +2588,7 @@ static struct dma_pl330_desc *pluck_desc(struct list_head *pool, desc->status = PREP; desc->txd.callback = NULL; + desc->txd.callback_result = NULL; } spin_unlock_irqrestore(lock, flags); |