diff options
| author | Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2018-11-07 09:04:54 -0500 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2018-11-23 06:20:01 -0500 |
| commit | 52117be68b82ee05c96da0a7beec319906ccf6cc (patch) | |
| tree | 199ca34f17ac36aeec05f92f00ef3e1cb75844ab | |
| parent | e10b40f3304360d3a2d07d690ff12197f828f2c8 (diff) | |
| download | linux-52117be68b82ee05c96da0a7beec319906ccf6cc.tar.gz linux-52117be68b82ee05c96da0a7beec319906ccf6cc.tar.bz2 linux-52117be68b82ee05c96da0a7beec319906ccf6cc.zip | |
media: vim2m: use cancel_delayed_work_sync instead of flush_schedule_work
The use of flush_schedule_work() made no sense and caused a syzkaller error.
Replace with the correct cancel_delayed_work_sync().
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reported-by: syzbot+69780d144754b8071f4b@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org> # for v4.20 and up
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
| -rw-r--r-- | drivers/media/platform/vim2m.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c index 035c7b7c8d87..d01821a6906a 100644 --- a/drivers/media/platform/vim2m.c +++ b/drivers/media/platform/vim2m.c @@ -803,10 +803,11 @@ static int vim2m_start_streaming(struct vb2_queue *q, unsigned count) static void vim2m_stop_streaming(struct vb2_queue *q) { struct vim2m_ctx *ctx = vb2_get_drv_priv(q); + struct vim2m_dev *dev = ctx->dev; struct vb2_v4l2_buffer *vbuf; unsigned long flags; - flush_scheduled_work(); + cancel_delayed_work_sync(&dev->work_run); for (;;) { if (V4L2_TYPE_IS_OUTPUT(q->type)) vbuf = v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx); |