summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStanimir Varbanov <stanimir.varbanov@linaro.org>2015-11-24 11:36:52 +0200
committerBjorn Helgaas <bhelgaas@google.com>2015-11-24 14:06:41 -0600
commit5228e39e3f709c82e6c4643402fc25de54391e32 (patch)
tree4c9ab4e1079907b3d6e97a0201bcb870d9bf62a9
parent3dcc8d39cf15fa3ceabedcffcbd3958fe953555a (diff)
downloadlinux-5228e39e3f709c82e6c4643402fc25de54391e32.tar.gz
linux-5228e39e3f709c82e6c4643402fc25de54391e32.tar.bz2
linux-5228e39e3f709c82e6c4643402fc25de54391e32.zip
PCI: designware: Remove incorrect io_base assignment
"pp->io" is an I/O resource, e.g., "[io 0x0000-0xffff]"; "pp->io_base" is the CPU physical address of a region where the host bridge converts CPU memory accesses into PCI I/O transactions. Corrupting pp->io_base by assigning pp->io->start to it breaks access to the PCI I/O space, as reported by Kishon. Remove the invalid assignment. [bhelgaas: changelog] Fixes: 0021d22b73d6 ("PCI: designware: Use of_pci_get_host_bridge_resources() to parse DT") Reported-and-tested-by: Kishon Vijay Abraham I <kishon@ti.com> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
-rw-r--r--drivers/pci/host/pcie-designware.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 540f077c37ea..02a7452bdf23 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp)
ret, pp->io);
continue;
}
- pp->io_base = pp->io->start;
break;
case IORESOURCE_MEM:
pp->mem = win->res;