diff options
| author | Kees Cook <keescook@chromium.org> | 2023-09-15 13:15:17 -0700 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2023-10-02 09:48:52 -0700 |
| commit | 5234193ee2b997e59326b047610a8f3f64a0ce02 (patch) | |
| tree | e1bfe510cabbd65d6d496a241dba25d7b696f07e | |
| parent | e91673b8dc59d7370492c653b84680503cac3aec (diff) | |
| download | linux-5234193ee2b997e59326b047610a8f3f64a0ce02.tar.gz linux-5234193ee2b997e59326b047610a8f3f64a0ce02.tar.bz2 linux-5234193ee2b997e59326b047610a8f3f64a0ce02.zip | |
ceph: Annotate struct ceph_osd_request with __counted_by
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct ceph_osd_request.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc: Ilya Dryomov <idryomov@gmail.com>
Cc: Xiubo Li <xiubli@redhat.com>
Cc: Jeff Layton <jlayton@kernel.org>
Cc: ceph-devel@vger.kernel.org
Reviewed-by: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Link: https://lore.kernel.org/r/20230915201517.never.373-kees@kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
| -rw-r--r-- | include/linux/ceph/osd_client.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/ceph/osd_client.h b/include/linux/ceph/osd_client.h index bf9823956758..b8610e9d2471 100644 --- a/include/linux/ceph/osd_client.h +++ b/include/linux/ceph/osd_client.h @@ -278,7 +278,7 @@ struct ceph_osd_request { int r_attempts; u32 r_map_dne_bound; - struct ceph_osd_req_op r_ops[]; + struct ceph_osd_req_op r_ops[] __counted_by(r_num_ops); }; struct ceph_request_redirect { |