diff options
| author | Daniel Thompson <daniel.thompson@linaro.org> | 2014-10-24 15:29:57 +0100 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2014-10-29 14:46:21 +0100 |
| commit | 5887010040c9ff4c5d41781075f64116f5f1c781 (patch) | |
| tree | db85a5ad3ff609bb74ae0ae4ce95a169b26dd577 | |
| parent | 8b648f13b4daa6c713691935aef7e64a7ff09a86 (diff) | |
| download | linux-5887010040c9ff4c5d41781075f64116f5f1c781.tar.gz linux-5887010040c9ff4c5d41781075f64116f5f1c781.tar.bz2 linux-5887010040c9ff4c5d41781075f64116f5f1c781.zip | |
gpio: msm-v1: make boolean argument more obvious
irq_set_irq_wake() treats its second argument as a boolean. It is much
easier to read code when constant booleans are either 0 or 1!
This particular line of code distracted me somewhat when I was doing a bit of
work in a code browser since it (spuriously) got me worried that I had
misunderstood how irq_set_irq_wake() worked.
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
[jkosina@suse.cz: alter subject to be more descriptive]
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
| -rw-r--r-- | drivers/gpio/gpio-msm-v1.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-msm-v1.c b/drivers/gpio/gpio-msm-v1.c index 73b73969d361..997e61ef173c 100644 --- a/drivers/gpio/gpio-msm-v1.c +++ b/drivers/gpio/gpio-msm-v1.c @@ -686,7 +686,7 @@ static int gpio_msm_v1_probe(struct platform_device *pdev) irq_set_chained_handler(irq1, msm_gpio_irq_handler); irq_set_chained_handler(irq2, msm_gpio_irq_handler); irq_set_irq_wake(irq1, 1); - irq_set_irq_wake(irq2, 2); + irq_set_irq_wake(irq2, 1); return 0; } |