diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2020-10-11 11:11:35 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2020-10-11 11:11:35 -0700 |
| commit | 5b697f86f9f136d200c9827d6eca0437b7eb96cf (patch) | |
| tree | c6e57bb516131f673a9b77293e1a9db136bf1365 | |
| parent | c120ec12e216225f7536cc1b924fe428ff64b5bd (diff) | |
| parent | 8a018eb55e3ac033592afbcb476b0ffe64465b12 (diff) | |
| download | linux-5b697f86f9f136d200c9827d6eca0437b7eb96cf.tar.gz linux-5b697f86f9f136d200c9827d6eca0437b7eb96cf.tar.bz2 linux-5b697f86f9f136d200c9827d6eca0437b7eb96cf.zip | |
Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull vfs fix from Al Viro:
"Fixes an obvious bug (memory leak introduced in 5.8)"
* 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
pipe: Fix memory leaks in create_pipe_files()
| -rw-r--r-- | fs/pipe.c | 11 | ||||
| -rw-r--r-- | include/linux/watch_queue.h | 6 |
2 files changed, 11 insertions, 6 deletions
diff --git a/fs/pipe.c b/fs/pipe.c index 117db82b10af..0ac197658a2d 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -894,19 +894,18 @@ int create_pipe_files(struct file **res, int flags) { struct inode *inode = get_pipe_inode(); struct file *f; + int error; if (!inode) return -ENFILE; if (flags & O_NOTIFICATION_PIPE) { -#ifdef CONFIG_WATCH_QUEUE - if (watch_queue_init(inode->i_pipe) < 0) { + error = watch_queue_init(inode->i_pipe); + if (error) { + free_pipe_info(inode->i_pipe); iput(inode); - return -ENOMEM; + return error; } -#else - return -ENOPKG; -#endif } f = alloc_file_pseudo(inode, pipe_mnt, "", diff --git a/include/linux/watch_queue.h b/include/linux/watch_queue.h index 5e08db2adc31..c994d1b2cdba 100644 --- a/include/linux/watch_queue.h +++ b/include/linux/watch_queue.h @@ -122,6 +122,12 @@ static inline void remove_watch_list(struct watch_list *wlist, u64 id) */ #define watch_sizeof(STRUCT) (sizeof(STRUCT) << WATCH_INFO_LENGTH__SHIFT) +#else +static inline int watch_queue_init(struct pipe_inode_info *pipe) +{ + return -ENOPKG; +} + #endif #endif /* _LINUX_WATCH_QUEUE_H */ |