summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHannes Eder <hannes@hanneseder.net>2009-02-25 22:29:29 +0100
committerTakashi Iwai <tiwai@suse.de>2009-02-26 09:55:17 +0100
commit5d44aa4c7322e0cda6d71cc3f0dffaceea0daae5 (patch)
tree66b87d15c67b7cff901d2c17eb3d0e481bab2198
parenteca985d28e1a8092ba2686ec5485fd688df5cfb3 (diff)
downloadlinux-5d44aa4c7322e0cda6d71cc3f0dffaceea0daae5.tar.gz
linux-5d44aa4c7322e0cda6d71cc3f0dffaceea0daae5.tar.bz2
linux-5d44aa4c7322e0cda6d71cc3f0dffaceea0daae5.zip
sound/oss: fix sparse warnings: different signedness
Impact: Change signature of 'set_volume_stereo' and 'set_volume_mono'. Fix this sparse warnings: sound/oss/pss.c:545:42: warning: incorrect type in argument 2 (different signedness) sound/oss/pss.c:546:42: warning: incorrect type in argument 3 (different signedness) sound/oss/pss.c:554:59: warning: incorrect type in argument 2 (different signedness) sound/oss/pss.c:560:59: warning: incorrect type in argument 2 (different signedness) sound/oss/pss.c:566:59: warning: incorrect type in argument 2 (different signedness) Signed-off-by: Hannes Eder <hannes@hanneseder.net> Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/oss/pss.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/sound/oss/pss.c b/sound/oss/pss.c
index 16ed06950dc1..16517a5a1301 100644
--- a/sound/oss/pss.c
+++ b/sound/oss/pss.c
@@ -457,10 +457,9 @@ static void pss_mixer_reset(pss_confdata *devc)
}
}
-static int set_volume_mono(unsigned __user *p, int *aleft)
+static int set_volume_mono(unsigned __user *p, unsigned int *aleft)
{
- int left;
- unsigned volume;
+ unsigned int left, volume;
if (get_user(volume, p))
return -EFAULT;
@@ -471,10 +470,11 @@ static int set_volume_mono(unsigned __user *p, int *aleft)
return 0;
}
-static int set_volume_stereo(unsigned __user *p, int *aleft, int *aright)
+static int set_volume_stereo(unsigned __user *p,
+ unsigned int *aleft,
+ unsigned int *aright)
{
- int left, right;
- unsigned volume;
+ unsigned int left, right, volume;
if (get_user(volume, p))
return -EFAULT;