diff options
| author | Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> | 2015-11-16 13:02:47 +0800 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2015-11-19 09:24:40 +0100 |
| commit | 5ed41cc4baaf4127661d2a8f8f2ee6e3085e0fa9 (patch) | |
| tree | cde0d7d31e4deab80a6def316ba661ef3873a0f2 | |
| parent | ef7c7553039b3d1c847b38b0f1ea208f8d5d8370 (diff) | |
| download | linux-5ed41cc4baaf4127661d2a8f8f2ee6e3085e0fa9.tar.gz linux-5ed41cc4baaf4127661d2a8f8f2ee6e3085e0fa9.tar.bz2 linux-5ed41cc4baaf4127661d2a8f8f2ee6e3085e0fa9.zip | |
gpiolib: do not allow to insert an empty gpiochip
We need to check if number of gpio is positive if there is no
such check in devicetree or acpi or whatever called before
gpiochip_add.
I suppose that devicetree and acpi do not allow insert gpiochip
with zero number but I do not know if it is enough to ignore
this check in gpiochip_add.
Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| -rw-r--r-- | drivers/gpio/gpiolib.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index eed70c36e8ac..89e01538e40e 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -325,6 +325,11 @@ int gpiochip_add(struct gpio_chip *chip) if (!descs) return -ENOMEM; + if (chip->ngpio == 0) { + chip_err(chip, "tried to insert a GPIO chip with zero lines\n"); + return -EINVAL; + } + spin_lock_irqsave(&gpio_lock, flags); if (base < 0) { |