diff options
| author | Krzysztof Kozlowski <k.kozlowski@samsung.com> | 2015-06-08 10:35:49 +0900 |
|---|---|---|
| committer | Eduardo Valentin <edubezval@gmail.com> | 2015-08-02 19:36:57 -0700 |
| commit | 5f09a5cbd14ae16e93866040fa44d930ff885650 (patch) | |
| tree | 69df2475150bcfef84b350f70dd889358d5e1f09 | |
| parent | d5f831090191fa26a539e12456af64547ab11dde (diff) | |
| download | linux-5f09a5cbd14ae16e93866040fa44d930ff885650.tar.gz linux-5f09a5cbd14ae16e93866040fa44d930ff885650.tar.bz2 linux-5f09a5cbd14ae16e93866040fa44d930ff885650.zip | |
thermal: exynos: Disable the regulator on probe failure
During probe the regulator (if present) was enabled but not disabled in
case of failure. So an unsuccessful probe lead to enabling the
regulator which was actually not needed because the device was not
enabled.
Additionally each deferred probe lead to increase of regulator enable
count so it would not be effectively disabled during removal of the
device.
Test HW: Exynos4412 - Trats2 board
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: 498d22f616f6 ("thermal: exynos: Support for TMU regulator defined at device tree")
Cc: <stable@vger.kernel.org>
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Tested-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
| -rw-r--r-- | drivers/thermal/samsung/exynos_tmu.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 531f4b179871..13c3aceed19d 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -1392,6 +1392,8 @@ err_clk_sec: if (!IS_ERR(data->clk_sec)) clk_unprepare(data->clk_sec); err_sensor: + if (!IS_ERR_OR_NULL(data->regulator)) + regulator_disable(data->regulator); thermal_zone_of_sensor_unregister(&pdev->dev, data->tzd); return ret; |