diff options
| author | Nikita Yushchenko <nikita.yoush@cogentembedded.com> | 2017-01-11 21:56:31 +0300 |
|---|---|---|
| committer | Konrad Rzeszutek Wilk <konrad@kernel.org> | 2017-01-15 12:37:24 -0500 |
| commit | 602d9858f07c72eab64f5f00e2fae55f9902cfbe (patch) | |
| tree | 274545ab1eed32ac6528047ad363c169753b1f7e | |
| parent | 7453c549f5f6485c0d79cad7844870dcc7d1b34d (diff) | |
| download | linux-602d9858f07c72eab64f5f00e2fae55f9902cfbe.tar.gz linux-602d9858f07c72eab64f5f00e2fae55f9902cfbe.tar.bz2 linux-602d9858f07c72eab64f5f00e2fae55f9902cfbe.zip | |
swiotlb: ensure that page-sized mappings are page-aligned
Some drivers do depend on page mappings to be page aligned.
Swiotlb already enforces such alignment for mappings greater than page,
extend that to page-sized mappings as well.
Without this fix, nvme hits BUG() in nvme_setup_prps(), because that routine
assumes page-aligned mappings.
Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Konrad Rzeszutek Wilk <konrad@kernel.org>
| -rw-r--r-- | lib/swiotlb.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/swiotlb.c b/lib/swiotlb.c index 975b8fc4f1e1..a8d74a733a38 100644 --- a/lib/swiotlb.c +++ b/lib/swiotlb.c @@ -483,11 +483,11 @@ phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, : 1UL << (BITS_PER_LONG - IO_TLB_SHIFT); /* - * For mappings greater than a page, we limit the stride (and - * hence alignment) to a page size. + * For mappings greater than or equal to a page, we limit the stride + * (and hence alignment) to a page size. */ nslots = ALIGN(size, 1 << IO_TLB_SHIFT) >> IO_TLB_SHIFT; - if (size > PAGE_SIZE) + if (size >= PAGE_SIZE) stride = (1 << (PAGE_SHIFT - IO_TLB_SHIFT)); else stride = 1; |