summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2010-05-19 10:11:14 -0700
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2010-05-19 10:14:31 -0700
commit641d446f89314d19fe17fcb9f19659a09fabe418 (patch)
tree8b1209478ba054dc939c7cf690d899c0c7ecbcc6
parent685afae02557a178185a4be36f58332976e79f63 (diff)
downloadlinux-641d446f89314d19fe17fcb9f19659a09fabe418.tar.gz
linux-641d446f89314d19fe17fcb9f19659a09fabe418.tar.bz2
linux-641d446f89314d19fe17fcb9f19659a09fabe418.zip
Input: usbtouchscreen - switch to using kmemdup()
Use kmemdup when some other buffer is immediately copied into the allocated region. Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
-rw-r--r--drivers/input/touchscreen/usbtouchscreen.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
index 99330bbdbac7..0b0ae2e17a60 100644
--- a/drivers/input/touchscreen/usbtouchscreen.c
+++ b/drivers/input/touchscreen/usbtouchscreen.c
@@ -811,12 +811,11 @@ static int nexio_init(struct usbtouch_usb *usbtouch)
priv = usbtouch->priv;
- priv->ack_buf = kmalloc(sizeof(nexio_ack_pkt), GFP_KERNEL);
+ priv->ack_buf = kmemdup(nexio_ack_pkt, sizeof(nexio_ack_pkt),
+ GFP_KERNEL);
if (!priv->ack_buf)
goto err_priv;
- memcpy(priv->ack_buf, nexio_ack_pkt, sizeof(nexio_ack_pkt));
-
priv->ack = usb_alloc_urb(0, GFP_KERNEL);
if (!priv->ack) {
dbg("%s - usb_alloc_urb failed: usbtouch->ack", __func__);