diff options
| author | Jia-Ju Bai <baijiaju1990@163.com> | 2017-12-12 16:49:52 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-12-13 14:52:57 -0500 |
| commit | 6e266610eb6553cfb7e7eb5d11914bd01509c406 (patch) | |
| tree | 63f92663cda1108f32af035052ddd56c8f3c847b | |
| parent | d6da83813fb39206c73cfb98798cc3c770e5b0a0 (diff) | |
| download | linux-6e266610eb6553cfb7e7eb5d11914bd01509c406.tar.gz linux-6e266610eb6553cfb7e7eb5d11914bd01509c406.tar.bz2 linux-6e266610eb6553cfb7e7eb5d11914bd01509c406.zip | |
hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close
The driver may sleep under a spinlock.
The function call path is:
rr_close (acquire the spinlock)
free_irq --> may sleep
To fix it, free_irq is moved to the place without holding the spinlock.
This bug is found by my static analysis tool(DSAC) and checked by my code review.
Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/hippi/rrunner.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/hippi/rrunner.c b/drivers/net/hippi/rrunner.c index 8483f03d5a41..1ab97d99b9ba 100644 --- a/drivers/net/hippi/rrunner.c +++ b/drivers/net/hippi/rrunner.c @@ -1379,8 +1379,8 @@ static int rr_close(struct net_device *dev) rrpriv->info_dma); rrpriv->info = NULL; - free_irq(pdev->irq, dev); spin_unlock_irqrestore(&rrpriv->lock, flags); + free_irq(pdev->irq, dev); return 0; } |