diff options
| author | Sakari Ailus <sakari.ailus@linux.intel.com> | 2023-12-06 19:22:03 +0200 |
|---|---|---|
| committer | Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2023-12-08 10:04:12 +0100 |
| commit | 72c8cb48a4cc05e8132725250b801326966c5c93 (patch) | |
| tree | e90e08d16cb8e931ad27805b4604ea0619434198 | |
| parent | dff1eebf2be36278d2669504ad9249f1d7505bc0 (diff) | |
| download | linux-72c8cb48a4cc05e8132725250b801326966c5c93.tar.gz linux-72c8cb48a4cc05e8132725250b801326966c5c93.tar.bz2 linux-72c8cb48a4cc05e8132725250b801326966c5c93.zip | |
media: mt9t112: Don't set format in sub-device state
For the purpose of setting old non-pad based sub-device try format as a
basis for VIDIOC_TRY_FMT implementation, there is no need to set the
format in the sub-device state. Drop the assignment to the state, which
would result in a NULL pointer dereference.
Fixes: fd17e3a9a788 ("media: i2c: Use accessors for pad config 'try_*' fields")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
| -rw-r--r-- | drivers/media/i2c/mt9t112.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/media/i2c/mt9t112.c b/drivers/media/i2c/mt9t112.c index 2e2d9853c089..fb1588c57cc8 100644 --- a/drivers/media/i2c/mt9t112.c +++ b/drivers/media/i2c/mt9t112.c @@ -982,7 +982,6 @@ static int mt9t112_set_fmt(struct v4l2_subdev *sd, if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE) return mt9t112_s_fmt(sd, mf); - *v4l2_subdev_state_get_format(sd_state, 0) = *mf; return 0; } |