diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2024-03-29 11:35:40 +0100 |
|---|---|---|
| committer | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2024-03-29 13:50:10 +0100 |
| commit | 73dfe970c038d0548beccc5bfb2707e1d543b01f (patch) | |
| tree | 7a2a28a0bdcf88d0610f8bfdbc48ed0f80fbaa84 | |
| parent | 9eb05877dbee03064d3d3483cd6702f610d5a358 (diff) | |
| download | linux-73dfe970c038d0548beccc5bfb2707e1d543b01f.tar.gz linux-73dfe970c038d0548beccc5bfb2707e1d543b01f.tar.bz2 linux-73dfe970c038d0548beccc5bfb2707e1d543b01f.zip | |
pwm: Fix setting period with #pwm-cells = <1> and of_pwm_single_xlate()
For drivers making use of of_pwm_single_xlate() (i.e. those that don't
pass a hwpwm index) and also don't pass flags, setting period was
wrongly skipped. This affects the pwm-pxa and ti-sn65dsi86 drivers.
Reported-by: Karel Balej <balejk@matfyz.cz>
Link: https://lore.kernel.org/r/D05IVTPYH35N.2CLDG6LSILRSN@matfyz.cz
Fixes: 40ade0c2e794 ("pwm: Let the of_xlate callbacks accept references without period")
Tested-by: Karel Balej <balejk@matfyz.cz>
Link: https://lore.kernel.org/r/20240329103544.545290-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| -rw-r--r-- | drivers/pwm/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index d70f793ce4b3..403525cc1783 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -443,7 +443,7 @@ of_pwm_single_xlate(struct pwm_chip *chip, const struct of_phandle_args *args) if (IS_ERR(pwm)) return pwm; - if (args->args_count > 1) + if (args->args_count > 0) pwm->args.period = args->args[0]; pwm->args.polarity = PWM_POLARITY_NORMAL; |