diff options
| author | Nathan Chancellor <natechancellor@gmail.com> | 2020-02-08 07:10:52 -0700 |
|---|---|---|
| committer | Vasily Gorbik <gor@linux.ibm.com> | 2020-02-17 18:01:58 +0100 |
| commit | 788d671517b5c81efbed9310ccbadb8cca86a08e (patch) | |
| tree | 1fe64eb87142c40d27446cca4be4bb998709080a | |
| parent | 380324734956c64cd060e1db4304f3117ac15809 (diff) | |
| download | linux-788d671517b5c81efbed9310ccbadb8cca86a08e.tar.gz linux-788d671517b5c81efbed9310ccbadb8cca86a08e.tar.bz2 linux-788d671517b5c81efbed9310ccbadb8cca86a08e.zip | |
s390/kaslr: Fix casts in get_random
Clang warns:
../arch/s390/boot/kaslr.c:78:25: warning: passing 'char *' to parameter
of type 'const u8 *' (aka 'const unsigned char *') converts between
pointers to integer
types with different sign [-Wpointer-sign]
(char *) entropy, (char *) entropy,
^~~~~~~~~~~~~~~~
../arch/s390/include/asm/cpacf.h:280:28: note: passing argument to
parameter 'src' here
u8 *dest, const u8 *src, long src_len)
^
2 warnings generated.
Fix the cast to match what else is done in this function.
Fixes: b2d24b97b2a9 ("s390/kernel: add support for kernel address space layout randomization (KASLR)")
Link: https://github.com/ClangBuiltLinux/linux/issues/862
Link: https://lkml.kernel.org/r/20200208141052.48476-1-natechancellor@gmail.com
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
| -rw-r--r-- | arch/s390/boot/kaslr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/s390/boot/kaslr.c b/arch/s390/boot/kaslr.c index 5d12352545c5..5591243d673e 100644 --- a/arch/s390/boot/kaslr.c +++ b/arch/s390/boot/kaslr.c @@ -75,7 +75,7 @@ static unsigned long get_random(unsigned long limit) *(unsigned long *) prng.parm_block ^= seed; for (i = 0; i < 16; i++) { cpacf_kmc(CPACF_KMC_PRNG, prng.parm_block, - (char *) entropy, (char *) entropy, + (u8 *) entropy, (u8 *) entropy, sizeof(entropy)); memcpy(prng.parm_block, entropy, sizeof(entropy)); } |