diff options
| author | Charlie Jenkins <charlie@rivosinc.com> | 2024-01-04 11:42:47 -0800 |
|---|---|---|
| committer | Palmer Dabbelt <palmer@rivosinc.com> | 2024-01-10 06:48:11 -0800 |
| commit | 78996eee79ebdfe8b6f0e54cb6dcc792d5129291 (patch) | |
| tree | bf943ffa12163a045b9b57ef6a1b2649faf9e5d6 | |
| parent | ed5b7cfd7839f9280a63365c1133482b42d0981f (diff) | |
| download | linux-78996eee79ebdfe8b6f0e54cb6dcc792d5129291.tar.gz linux-78996eee79ebdfe8b6f0e54cb6dcc792d5129291.tar.bz2 linux-78996eee79ebdfe8b6f0e54cb6dcc792d5129291.zip | |
riscv: Fix module loading free order
Reverse order of kfree calls to resolve use-after-free error.
Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
Fixes: d8792a5734b0 ("riscv: Safely remove entries from relocation list")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202312132019.iYGTwW0L-lkp@intel.com/
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@inria.fr>
Closes: https://lore.kernel.org/r/202312120044.wTI1Uyaa-lkp@intel.com/
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240104-module_loading_fix-v3-1-a71f8de6ce0f@rivosinc.com
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
| -rw-r--r-- | arch/riscv/kernel/module.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c index aac019ed63b1..21c7a773a8ef 100644 --- a/arch/riscv/kernel/module.c +++ b/arch/riscv/kernel/module.c @@ -723,8 +723,8 @@ static int add_relocation_to_accumulate(struct module *me, int type, if (!bucket) { kfree(entry); - kfree(rel_head); kfree(rel_head->rel_entry); + kfree(rel_head); return -ENOMEM; } |