diff options
| author | Jiri Kosina <jkosina@suse.cz> | 2016-05-24 16:38:10 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2016-05-24 09:00:40 -0600 |
| commit | 7c87df9c159aa1d228f0d77b37942216cff34922 (patch) | |
| tree | 2cb7df6171554ba8547681b42fa3f9a6d6b02912 | |
| parent | ba36c21b0cd8b55fd7f010e9052656c2c03d9e5e (diff) | |
| download | linux-7c87df9c159aa1d228f0d77b37942216cff34922.tar.gz linux-7c87df9c159aa1d228f0d77b37942216cff34922.tar.bz2 linux-7c87df9c159aa1d228f0d77b37942216cff34922.zip | |
bcache: bch_writeback_thread() is not freezable
bch_writeback_thread() is calling try_to_freeze(), but that's just an
expensive no-op given the fact that the thread is not marked freezable.
I/O helper kthreads, exactly such as the bcache writeback thread, actually
shouldn't be freezable, because they are potentially necessary for
finalizing the image write-out.
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Jens Axboe <axboe@fb.com>
| -rw-r--r-- | drivers/md/bcache/writeback.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c index b9346cd9cda1..60123677b382 100644 --- a/drivers/md/bcache/writeback.c +++ b/drivers/md/bcache/writeback.c @@ -12,7 +12,6 @@ #include "writeback.h" #include <linux/delay.h> -#include <linux/freezer.h> #include <linux/kthread.h> #include <trace/events/bcache.h> @@ -228,7 +227,6 @@ static void read_dirty(struct cached_dev *dc) */ while (!kthread_should_stop()) { - try_to_freeze(); w = bch_keybuf_next(&dc->writeback_keys); if (!w) @@ -433,7 +431,6 @@ static int bch_writeback_thread(void *arg) if (kthread_should_stop()) return 0; - try_to_freeze(); schedule(); continue; } |