diff options
| author | Anant Thazhemadam <anant.thazhemadam@gmail.com> | 2020-10-12 09:54:04 +0530 |
|---|---|---|
| committer | Dominique Martinet <asmadeus@codewreck.org> | 2020-10-12 10:05:47 +0200 |
| commit | 7ca1db21ef8e0e6725b4d25deed1ca196f7efb28 (patch) | |
| tree | 95f1225ce898c15c14a7eecb8203940ed25b96b8 | |
| parent | 316a1bef0d1622410c9f0f301173d0a03168ce37 (diff) | |
| download | linux-7ca1db21ef8e0e6725b4d25deed1ca196f7efb28.tar.gz linux-7ca1db21ef8e0e6725b4d25deed1ca196f7efb28.tar.bz2 linux-7ca1db21ef8e0e6725b4d25deed1ca196f7efb28.zip | |
net: 9p: initialize sun_server.sun_path to have addr's value only when addr is valid
In p9_fd_create_unix, checking is performed to see if the addr (passed
as an argument) is NULL or not.
However, no check is performed to see if addr is a valid address, i.e.,
it doesn't entirely consist of only 0's.
The initialization of sun_server.sun_path to be equal to this faulty
addr value leads to an uninitialized variable, as detected by KMSAN.
Checking for this (faulty addr) and returning a negative error number
appropriately, resolves this issue.
Link: http://lkml.kernel.org/r/20201012042404.2508-1-anant.thazhemadam@gmail.com
Reported-by: syzbot+75d51fe5bf4ebe988518@syzkaller.appspotmail.com
Tested-by: syzbot+75d51fe5bf4ebe988518@syzkaller.appspotmail.com
Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
| -rw-r--r-- | net/9p/trans_fd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c index c0762a302162..8f528e783a6c 100644 --- a/net/9p/trans_fd.c +++ b/net/9p/trans_fd.c @@ -1023,7 +1023,7 @@ p9_fd_create_unix(struct p9_client *client, const char *addr, char *args) csocket = NULL; - if (addr == NULL) + if (!addr || !strlen(addr)) return -EINVAL; if (strlen(addr) >= UNIX_PATH_MAX) { |