diff options
| author | Sachin Kamat <sachin.kamat@linaro.org> | 2013-03-04 14:05:42 +0530 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2013-03-04 13:08:48 +0200 |
| commit | 862421da0d82a3c35aa89e040a533f76d24c62c4 (patch) | |
| tree | cc2de3bfdfe27bed3aa0bcdb8f66232fb9deedcd | |
| parent | a40070410329fb704aedf9451732ffb92a3fe39f (diff) | |
| download | linux-862421da0d82a3c35aa89e040a533f76d24c62c4.tar.gz linux-862421da0d82a3c35aa89e040a533f76d24c62c4.tar.bz2 linux-862421da0d82a3c35aa89e040a533f76d24c62c4.zip | |
usb: phy: omap-usb3: Convert to devm_ioremap_resource()
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.
Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
| -rw-r--r-- | drivers/usb/phy/omap-usb3.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/usb/phy/omap-usb3.c b/drivers/usb/phy/omap-usb3.c index fadc0c2b65bb..a6e60b1e102e 100644 --- a/drivers/usb/phy/omap-usb3.c +++ b/drivers/usb/phy/omap-usb3.c @@ -212,11 +212,9 @@ static int omap_usb3_probe(struct platform_device *pdev) } res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "pll_ctrl"); - phy->pll_ctrl_base = devm_request_and_ioremap(&pdev->dev, res); - if (!phy->pll_ctrl_base) { - dev_err(&pdev->dev, "ioremap of pll_ctrl failed\n"); - return -ENOMEM; - } + phy->pll_ctrl_base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(phy->pll_ctrl_base)) + return PTR_ERR(phy->pll_ctrl_base); phy->dev = &pdev->dev; |