diff options
| author | Raag Jadav <raag.jadav@intel.com> | 2024-01-02 11:20:06 +0530 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-01-04 16:21:51 +0100 |
| commit | 8c9aa6e1877de041e393b42a88e0cfd54627b3f7 (patch) | |
| tree | 89f7fecae32b57d8462f1d3cfa43a2eb38eadc65 | |
| parent | 9903f2f2e1c0306df5e35080552502659475e751 (diff) | |
| download | linux-8c9aa6e1877de041e393b42a88e0cfd54627b3f7.tar.gz linux-8c9aa6e1877de041e393b42a88e0cfd54627b3f7.tar.bz2 linux-8c9aa6e1877de041e393b42a88e0cfd54627b3f7.zip | |
serial: 8250_lpss: copy dma_param using devm_kmemdup()
Use devm_kmemdup() helper to copy dma_param instead of doing it manually.
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Link: https://lore.kernel.org/r/20240102055006.27256-1-raag.jadav@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/tty/serial/8250/8250_lpss.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/tty/serial/8250/8250_lpss.c b/drivers/tty/serial/8250/8250_lpss.c index 0e43bdfb7459..776ec1ef29d6 100644 --- a/drivers/tty/serial/8250/8250_lpss.c +++ b/drivers/tty/serial/8250/8250_lpss.c @@ -287,17 +287,14 @@ static int lpss8250_dma_setup(struct lpss8250 *lpss, struct uart_8250_port *port return 0; } - rx_param = devm_kzalloc(dev, sizeof(*rx_param), GFP_KERNEL); + rx_param = devm_kmemdup(dev, &lpss->dma_param, sizeof(*rx_param), GFP_KERNEL); if (!rx_param) return -ENOMEM; - tx_param = devm_kzalloc(dev, sizeof(*tx_param), GFP_KERNEL); + tx_param = devm_kmemdup(dev, &lpss->dma_param, sizeof(*tx_param), GFP_KERNEL); if (!tx_param) return -ENOMEM; - *rx_param = lpss->dma_param; - *tx_param = lpss->dma_param; - dma->fn = lpss8250_dma_filter; dma->rx_param = rx_param; dma->tx_param = tx_param; |