diff options
| author | Azeem Shaikh <azeemshaikh38@gmail.com> | 2023-05-17 14:31:30 +0000 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2023-05-26 13:52:19 -0700 |
| commit | 8d82557e4b5e948690db9d23bdde34fc1afa120f (patch) | |
| tree | cdddc35836efba7feccba383a906048e991f40ed | |
| parent | 2f4113b330810ab71efa0bd4bbd0655154cd2a70 (diff) | |
| download | linux-8d82557e4b5e948690db9d23bdde34fc1afa120f.tar.gz linux-8d82557e4b5e948690db9d23bdde34fc1afa120f.tar.bz2 linux-8d82557e4b5e948690db9d23bdde34fc1afa120f.zip | |
scsi: bnx2i: Replace all non-returning strlcpy with strscpy
strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230517143130.1519941-1-azeemshaikh38@gmail.com
| -rw-r--r-- | drivers/scsi/bnx2i/bnx2i_init.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c index 2b3f0c10478e..872ad37e2a6e 100644 --- a/drivers/scsi/bnx2i/bnx2i_init.c +++ b/drivers/scsi/bnx2i/bnx2i_init.c @@ -383,7 +383,7 @@ int bnx2i_get_stats(void *handle) if (!stats) return -ENOMEM; - strlcpy(stats->version, DRV_MODULE_VERSION, sizeof(stats->version)); + strscpy(stats->version, DRV_MODULE_VERSION, sizeof(stats->version)); memcpy(stats->mac_add1 + 2, hba->cnic->mac_addr, ETH_ALEN); stats->max_frame_size = hba->netdev->mtu; |