diff options
| author | Avi Kivity <avi@qumranet.com> | 2007-11-20 12:49:31 +0200 |
|---|---|---|
| committer | Avi Kivity <avi@qumranet.com> | 2008-01-30 17:53:09 +0200 |
| commit | 93a0039c8d93074d5f92dfb69f6a7d453905d002 (patch) | |
| tree | 23a693083f2bfcf85e161f64a2500bb7b13ad014 | |
| parent | b4231d61807cac8d9d257eb6979c1685fa9a171f (diff) | |
| download | linux-93a0039c8d93074d5f92dfb69f6a7d453905d002.tar.gz linux-93a0039c8d93074d5f92dfb69f6a7d453905d002.tar.bz2 linux-93a0039c8d93074d5f92dfb69f6a7d453905d002.zip | |
KVM: x86 emulator: retire ->write_std()
Theoretically used to acccess memory known to be ordinary RAM, it was
never implemented. It is questionable whether it is possible to implement
it correctly.
Signed-off-by: Avi Kivity <avi@qumranet.com>
| -rw-r--r-- | drivers/kvm/x86.c | 10 | ||||
| -rw-r--r-- | drivers/kvm/x86_emulate.h | 11 |
2 files changed, 0 insertions, 21 deletions
diff --git a/drivers/kvm/x86.c b/drivers/kvm/x86.c index 6212984a2e6c..5a54e328088d 100644 --- a/drivers/kvm/x86.c +++ b/drivers/kvm/x86.c @@ -1162,15 +1162,6 @@ int emulator_read_std(unsigned long addr, } EXPORT_SYMBOL_GPL(emulator_read_std); -static int emulator_write_std(unsigned long addr, - const void *val, - unsigned int bytes, - struct kvm_vcpu *vcpu) -{ - pr_unimpl(vcpu, "emulator_write_std: addr %lx n %d\n", addr, bytes); - return X86EMUL_UNHANDLEABLE; -} - static int emulator_read_emulated(unsigned long addr, void *val, unsigned int bytes, @@ -1367,7 +1358,6 @@ EXPORT_SYMBOL_GPL(kvm_report_emulation_failure); struct x86_emulate_ops emulate_ops = { .read_std = emulator_read_std, - .write_std = emulator_write_std, .read_emulated = emulator_read_emulated, .write_emulated = emulator_write_emulated, .cmpxchg_emulated = emulator_cmpxchg_emulated, diff --git a/drivers/kvm/x86_emulate.h b/drivers/kvm/x86_emulate.h index e34868b42c33..a62bf14bbf89 100644 --- a/drivers/kvm/x86_emulate.h +++ b/drivers/kvm/x86_emulate.h @@ -63,17 +63,6 @@ struct x86_emulate_ops { unsigned int bytes, struct kvm_vcpu *vcpu); /* - * write_std: Write bytes of standard (non-emulated/special) memory. - * Used for stack operations, and others. - * @addr: [IN ] Linear address to which to write. - * @val: [IN ] Value to write to memory (low-order bytes used as - * required). - * @bytes: [IN ] Number of bytes to write to memory. - */ - int (*write_std)(unsigned long addr, const void *val, - unsigned int bytes, struct kvm_vcpu *vcpu); - - /* * read_emulated: Read bytes from emulated/special memory area. * @addr: [IN ] Linear address from which to read. * @val: [OUT] Value read from memory, zero-extended to 'u_long'. |