summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJavier Martinez Canillas <javierm@redhat.com>2023-01-21 20:24:16 +0100
committerJavier Martinez Canillas <javierm@redhat.com>2023-01-24 11:02:18 +0100
commit998101f2a78cf506022f2094461105cb3d00e19f (patch)
tree9b9b1f1bc17fb8f680ee53168ffa7a5cde8a42eb
parent8681e3663411ee6b64dd0714b23f5c86f64f7533 (diff)
downloadlinux-998101f2a78cf506022f2094461105cb3d00e19f.tar.gz
linux-998101f2a78cf506022f2094461105cb3d00e19f.tar.bz2
linux-998101f2a78cf506022f2094461105cb3d00e19f.zip
fbdev: Remove unused struct fb_deferred_io .first_io field
This optional callback was added in the commit 1f45f9dbb392 ("fb_defio: add first_io callback") but it was never used by a driver. Let's remove it since it's unlikely that will be used after a decade that was added. Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Link: https://patchwork.freedesktop.org/patch/msgid/20230121192418.2814955-2-javierm@redhat.com
-rw-r--r--drivers/video/fbdev/core/fb_defio.c4
-rw-r--r--include/linux/fb.h1
2 files changed, 0 insertions, 5 deletions
diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video/fbdev/core/fb_defio.c
index c730253ab85c..1b680742b7f3 100644
--- a/drivers/video/fbdev/core/fb_defio.c
+++ b/drivers/video/fbdev/core/fb_defio.c
@@ -157,10 +157,6 @@ static vm_fault_t fb_deferred_io_track_page(struct fb_info *info, unsigned long
/* protect against the workqueue changing the page list */
mutex_lock(&fbdefio->lock);
- /* first write in this cycle, notify the driver */
- if (fbdefio->first_io && list_empty(&fbdefio->pagereflist))
- fbdefio->first_io(info);
-
pageref = fb_deferred_io_pageref_get(info, offset, page);
if (WARN_ON_ONCE(!pageref)) {
ret = VM_FAULT_OOM;
diff --git a/include/linux/fb.h b/include/linux/fb.h
index 30183fd259ae..daf336385613 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -215,7 +215,6 @@ struct fb_deferred_io {
struct mutex lock; /* mutex that protects the pageref list */
struct list_head pagereflist; /* list of pagerefs for touched pages */
/* callback */
- void (*first_io)(struct fb_info *info);
void (*deferred_io)(struct fb_info *info, struct list_head *pagelist);
};
#endif