diff options
| author | Stephen Rothwell <sfr@canb.auug.org.au> | 2024-11-08 16:41:27 +0100 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2024-11-11 11:49:47 +0100 |
| commit | 9a884bdb6e9560c6da44052d5248e89d78c983a6 (patch) | |
| tree | fb995cc0c1080e118e5cf8935c81f2eaac553788 | |
| parent | 5c2e7736e20d9b348a44cafbfa639fe2653fbc34 (diff) | |
| download | linux-9a884bdb6e9560c6da44052d5248e89d78c983a6.tar.gz linux-9a884bdb6e9560c6da44052d5248e89d78c983a6.tar.bz2 linux-9a884bdb6e9560c6da44052d5248e89d78c983a6.zip | |
iio: magnetometer: fix if () scoped_guard() formatting
Add mising braces after an if condition that contains scoped_guard().
This style is both preferred and necessary here, to fix warning after
scoped_guard() change in commit fcc22ac5baf0 ("cleanup: Adjust
scoped_guard() macros to avoid potential warning") to have if-else inside
of the macro. Current (no braces) use in af8133j_set_scale() yields
the following warnings:
af8133j.c:315:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else]
af8133j.c:316:3: warning: add explicit braces to avoid dangling else [-Wdangling-else]
Fixes: fcc22ac5baf0 ("cleanup: Adjust scoped_guard() macros to avoid potential warning")
Closes: https://lore.kernel.org/oe-kbuild-all/202409270848.tTpyEAR7-lkp@intel.com/
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20241108154258.21411-1-przemyslaw.kitszel@intel.com
| -rw-r--r-- | drivers/iio/magnetometer/af8133j.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/iio/magnetometer/af8133j.c b/drivers/iio/magnetometer/af8133j.c index d81d89af6283..acd291f3e792 100644 --- a/drivers/iio/magnetometer/af8133j.c +++ b/drivers/iio/magnetometer/af8133j.c @@ -312,10 +312,11 @@ static int af8133j_set_scale(struct af8133j_data *data, * When suspended, just store the new range to data->range to be * applied later during power up. */ - if (!pm_runtime_status_suspended(dev)) + if (!pm_runtime_status_suspended(dev)) { scoped_guard(mutex, &data->mutex) ret = regmap_write(data->regmap, AF8133J_REG_RANGE, range); + } pm_runtime_enable(dev); |