diff options
| author | Wolfram Sang <wsa+renesas@sang-engineering.com> | 2024-06-03 11:15:39 +0200 |
|---|---|---|
| committer | Kalle Valo <kvalo@kernel.org> | 2024-06-12 15:01:09 +0300 |
| commit | a2ead3445a6317c5d2b53711cf9a98e54c395223 (patch) | |
| tree | e50b057745cad2b6dcb78b650628ff1101574b63 | |
| parent | a37f6947ff07896d5132d6fbfec538de01c74287 (diff) | |
| download | linux-a2ead3445a6317c5d2b53711cf9a98e54c395223.tar.gz linux-a2ead3445a6317c5d2b53711cf9a98e54c395223.tar.bz2 linux-a2ead3445a6317c5d2b53711cf9a98e54c395223.zip | |
wifi: zd1211rw: use 'time_left' variable with wait_for_completion_timeout()
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:
timeout = wait_for_completion_timeout(...)
if (!timeout) return -ETIMEDOUT;
with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240603091541.8367-7-wsa+renesas@sang-engineering.com
| -rw-r--r-- | drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_usb.c b/drivers/net/wireless/zydas/zd1211rw/zd_usb.c index f3b567a13ded..2ee4218da1c5 100644 --- a/drivers/net/wireless/zydas/zd1211rw/zd_usb.c +++ b/drivers/net/wireless/zydas/zd1211rw/zd_usb.c @@ -1698,7 +1698,7 @@ int zd_usb_ioread16v(struct zd_usb *usb, u16 *values, int r, i, req_len, actual_req_len, try_count = 0; struct usb_device *udev; struct usb_req_read_regs *req = NULL; - unsigned long timeout; + unsigned long time_left; bool retry = false; if (count < 1) { @@ -1748,9 +1748,9 @@ retry_read: goto error; } - timeout = wait_for_completion_timeout(&usb->intr.read_regs.completion, - msecs_to_jiffies(50)); - if (!timeout) { + time_left = wait_for_completion_timeout(&usb->intr.read_regs.completion, + msecs_to_jiffies(50)); + if (!time_left) { disable_read_regs_int(usb); dev_dbg_f(zd_usb_dev(usb), "read timed out\n"); r = -ETIMEDOUT; |