diff options
| author | Colin Ian King <colin.king@canonical.com> | 2019-05-10 10:58:32 +0100 |
|---|---|---|
| committer | Philipp Zabel <p.zabel@pengutronix.de> | 2019-07-04 12:10:55 +0200 |
| commit | a71dcd3757e29cc8b43383ff18595d707cf08345 (patch) | |
| tree | b214062fd64dc92d0179d6d69a6d577835b5761c | |
| parent | a188339ca5a396acc588e5851ed7e19f66b0ebd9 (diff) | |
| download | linux-a71dcd3757e29cc8b43383ff18595d707cf08345.tar.gz linux-a71dcd3757e29cc8b43383ff18595d707cf08345.tar.bz2 linux-a71dcd3757e29cc8b43383ff18595d707cf08345.zip | |
reset: remove redundant null check on pointer dev
Pointer dev is being dereferenced when passed to the inlined
functon dev_name, however, dev is later being null checked
so at first this seems like a potential null pointer dereference.
In fact, _reset_control_get_from_lookup is only ever called from
__reset_control_get, right after checking dev->of_node hence
dev can never be null. Clean this up by removing the redundant
null check.
Thanks to Philipp Zabel for spotting that dev can never be null.
Addresses-Coverity: ("Dereference before null check")
Fixes: 6691dffab0ab ("reset: add support for non-DT systems")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
| -rw-r--r-- | drivers/reset/core.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/reset/core.c b/drivers/reset/core.c index 81ea77cba123..921f4bbbad8a 100644 --- a/drivers/reset/core.c +++ b/drivers/reset/core.c @@ -694,9 +694,6 @@ __reset_control_get_from_lookup(struct device *dev, const char *con_id, const char *dev_id = dev_name(dev); struct reset_control *rstc = NULL; - if (!dev) - return ERR_PTR(-EINVAL); - mutex_lock(&reset_lookup_mutex); list_for_each_entry(lookup, &reset_lookup_list, list) { |