diff options
| author | Yu Kuai <yukuai3@huawei.com> | 2020-11-26 11:18:34 +0800 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2020-12-02 12:44:20 -0700 |
| commit | acaf523a7bf226b28504306c1cfee194520123b3 (patch) | |
| tree | 1276fc9123fe78d2ac96b50e9b913063161d919f | |
| parent | b0d97557ebfc9d5ba5f2939339a9fdd267abafeb (diff) | |
| download | linux-acaf523a7bf226b28504306c1cfee194520123b3.tar.gz linux-acaf523a7bf226b28504306c1cfee194520123b3.tar.bz2 linux-acaf523a7bf226b28504306c1cfee194520123b3.zip | |
blk-throttle: don't check whether or not lower limit is valid if CONFIG_BLK_DEV_THROTTLING_LOW is off
blk_throtl_update_limit_valid() will search for descendants to see if
'LIMIT_LOW' of bps/iops and READ/WRITE is nonzero. However, they're always
zero if CONFIG_BLK_DEV_THROTTLING_LOW is not set, furthermore, a lot of
time will be wasted to iterate descendants.
Thus do nothing in blk_throtl_update_limit_valid() in such situation.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | block/blk-throttle.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/block/blk-throttle.c b/block/blk-throttle.c index b771c4299982..d52cac9f3a7c 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -587,6 +587,7 @@ static void throtl_pd_online(struct blkg_policy_data *pd) tg_update_has_rules(tg); } +#ifdef CONFIG_BLK_DEV_THROTTLING_LOW static void blk_throtl_update_limit_valid(struct throtl_data *td) { struct cgroup_subsys_state *pos_css; @@ -607,6 +608,11 @@ static void blk_throtl_update_limit_valid(struct throtl_data *td) td->limit_valid[LIMIT_LOW] = low_valid; } +#else +static inline void blk_throtl_update_limit_valid(struct throtl_data *td) +{ +} +#endif static void throtl_upgrade_state(struct throtl_data *td); static void throtl_pd_offline(struct blkg_policy_data *pd) |