diff options
| author | Alan Cox <alan@redhat.com> | 2009-01-02 13:50:20 +0000 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-01-02 10:19:43 -0800 |
| commit | ad36b88e2d22e9ef42797581d3ecea9feadd9488 (patch) | |
| tree | 7d06f166763cf7273aa9d784051c1df8f260b7af | |
| parent | c847d47cb7b2fa78b17c9e17ed3fbd010ee3d3ca (diff) | |
| download | linux-ad36b88e2d22e9ef42797581d3ecea9feadd9488.tar.gz linux-ad36b88e2d22e9ef42797581d3ecea9feadd9488.tar.bz2 linux-ad36b88e2d22e9ef42797581d3ecea9feadd9488.zip | |
tty: Fix an ircomm warning and note another bug
Roel Kluin noted that line is unsigned so one test is unneccessary. Also
add a warning for another flaw I noticed while making this change.
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | net/irda/ircomm/ircomm_tty.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/irda/ircomm/ircomm_tty.c b/net/irda/ircomm/ircomm_tty.c index e4e2caeb9d82..086d5ef098fd 100644 --- a/net/irda/ircomm/ircomm_tty.c +++ b/net/irda/ircomm/ircomm_tty.c @@ -371,9 +371,8 @@ static int ircomm_tty_open(struct tty_struct *tty, struct file *filp) IRDA_DEBUG(2, "%s()\n", __func__ ); line = tty->index; - if ((line < 0) || (line >= IRCOMM_TTY_PORTS)) { + if (line >= IRCOMM_TTY_PORTS) return -ENODEV; - } /* Check if instance already exists */ self = hashbin_lock_find(ircomm_tty, line, NULL); @@ -405,6 +404,8 @@ static int ircomm_tty_open(struct tty_struct *tty, struct file *filp) * Force TTY into raw mode by default which is usually what * we want for IrCOMM and IrLPT. This way applications will * not have to twiddle with printcap etc. + * + * Note this is completely usafe and doesn't work properly */ tty->termios->c_iflag = 0; tty->termios->c_oflag = 0; |