diff options
| author | Alexey Dobriyan <adobriyan@gmail.com> | 2022-10-20 12:49:45 +0300 |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2022-11-19 00:56:15 +0100 |
| commit | adcd7118caadac54666081be39bbbc3e9b5e1f7d (patch) | |
| tree | 25bdbb1332bdf7ac5404b40e6f9a897e10ec8d36 | |
| parent | 23a60a03d9a9980d1e91190491ceea0dc58fae62 (diff) | |
| download | linux-adcd7118caadac54666081be39bbbc3e9b5e1f7d.tar.gz linux-adcd7118caadac54666081be39bbbc3e9b5e1f7d.tar.bz2 linux-adcd7118caadac54666081be39bbbc3e9b5e1f7d.zip | |
perf/x86: Make struct p4_event_bind::cntr signed array
struct p4_event_bind::cntr[][] should be signed because of
the following code:
int i, j;
for (i = 0; i < P4_CNTR_LIMIT; i++) {
---> j = bind->cntr[thread][i];
if (j != -1 && !test_bit(j, used_mask))
return j;
}
Making this member unsigned will make "j" 255 and fail "j != -1"
comparison.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| -rw-r--r-- | arch/x86/events/intel/p4.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/events/intel/p4.c b/arch/x86/events/intel/p4.c index 03bbcc2fa2ff..35936188db01 100644 --- a/arch/x86/events/intel/p4.c +++ b/arch/x86/events/intel/p4.c @@ -24,7 +24,7 @@ struct p4_event_bind { unsigned int escr_msr[2]; /* ESCR MSR for this event */ unsigned int escr_emask; /* valid ESCR EventMask bits */ unsigned int shared; /* event is shared across threads */ - char cntr[2][P4_CNTR_LIMIT]; /* counter index (offset), -1 on absence */ + signed char cntr[2][P4_CNTR_LIMIT]; /* counter index (offset), -1 on absence */ }; struct p4_pebs_bind { |