diff options
| author | Fabian Frederick <fabf@skynet.be> | 2014-06-04 16:12:10 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-06-04 16:54:20 -0700 |
| commit | ae3ccc4678fec2d270a4c54981831c7b8a2da9cd (patch) | |
| tree | 20c42f0c1f8f12a2e82579bcfa2a5c960f0d0b78 | |
| parent | 9b3189eb424044e51c8847063b2ba314b57b6ed2 (diff) | |
| download | linux-ae3ccc4678fec2d270a4c54981831c7b8a2da9cd.tar.gz linux-ae3ccc4678fec2d270a4c54981831c7b8a2da9cd.tar.bz2 linux-ae3ccc4678fec2d270a4c54981831c7b8a2da9cd.zip | |
scripts/checkpatch.pl: device_initcall is not the only __initcall substitute
This patch adds a link to init.h to find appropriate initcall function to
replace obsolete __initcall
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rwxr-xr-x | scripts/checkpatch.pl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 0ef4ae1de8ee..010b18ef4ea0 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4551,10 +4551,10 @@ sub process { "$1 is obsolete, use k$3 instead\n" . $herecurr); } -# check for __initcall(), use device_initcall() explicitly please +# check for __initcall(), use device_initcall() explicitly or more appropriate function please if ($line =~ /^.\s*__initcall\s*\(/) { WARN("USE_DEVICE_INITCALL", - "please use device_initcall() instead of __initcall()\n" . $herecurr); + "please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr); } # check for various ops structs, ensure they are const. |