diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2018-07-12 14:43:20 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-07-16 13:35:47 -0700 |
| commit | ae85467cccba9b255bd91b583effb17a5b57a12f (patch) | |
| tree | a0d92ca10c367ff9f407262cae6d51905784bb77 | |
| parent | 2a6deb6a572e7b1c34ac8ab662346124c3c4d046 (diff) | |
| download | linux-ae85467cccba9b255bd91b583effb17a5b57a12f.tar.gz linux-ae85467cccba9b255bd91b583effb17a5b57a12f.tar.bz2 linux-ae85467cccba9b255bd91b583effb17a5b57a12f.zip | |
net: usb: hso: use swap macro in hso_kick_transmit
Make use of the swap macro and remove unnecessary variable *temp*.
This makes the code easier to read and maintain. Also, slightly
refactor some code due to the removal of *temp*.
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/usb/hso.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index de305ead32e6..184c24baca15 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c @@ -1732,7 +1732,6 @@ static int hso_serial_ioctl(struct tty_struct *tty, /* starts a transmit */ static void hso_kick_transmit(struct hso_serial *serial) { - u8 *temp; unsigned long flags; int res; @@ -1748,14 +1747,12 @@ static void hso_kick_transmit(struct hso_serial *serial) goto out; /* Switch pointers around to avoid memcpy */ - temp = serial->tx_buffer; - serial->tx_buffer = serial->tx_data; - serial->tx_data = temp; + swap(serial->tx_buffer, serial->tx_data); serial->tx_data_count = serial->tx_buffer_count; serial->tx_buffer_count = 0; - /* If temp is set, it means we switched buffers */ - if (temp && serial->write_data) { + /* If serial->tx_data is set, it means we switched buffers */ + if (serial->tx_data && serial->write_data) { res = serial->write_data(serial); if (res >= 0) serial->tx_urb_used = 1; |