diff options
| author | Yang Jihong <yangjihong1@huawei.com> | 2024-01-19 04:03:02 +0000 |
|---|---|---|
| committer | Namhyung Kim <namhyung@kernel.org> | 2024-01-22 12:08:20 -0800 |
| commit | aff10a165201f6f60cff225083ce301ad3f5d8f1 (patch) | |
| tree | 024a383d6cc7ddd2b9fdc97497d98460958bed33 | |
| parent | 55442cc2f22d0727abfecc3a30c605f04acff4b7 (diff) | |
| download | linux-aff10a165201f6f60cff225083ce301ad3f5d8f1.tar.gz linux-aff10a165201f6f60cff225083ce301ad3f5d8f1.tar.bz2 linux-aff10a165201f6f60cff225083ce301ad3f5d8f1.zip | |
perf record: Fix possible incorrect free in record__switch_output()
perf_data__switch() may not assign a legal value to 'new_filename'.
In this case, 'new_filename' uses the on-stack value, which may cause a
incorrect free and unexpected result.
Fixes: 03724b2e9c45 ("perf record: Allow to limit number of reported perf.data files")
Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240119040304.3708522-2-yangjihong1@huawei.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
| -rw-r--r-- | tools/perf/builtin-record.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 91e6828c38cc..fb8d4067b76c 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -1830,8 +1830,8 @@ static int record__switch_output(struct record *rec, bool at_exit) { struct perf_data *data = &rec->data; + char *new_filename = NULL; int fd, err; - char *new_filename; /* Same Size: "2015122520103046"*/ char timestamp[] = "InvalidTimestamp"; |