summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBruno Randolf <randolf.bruno@googlemail.com>2010-07-12 00:40:38 +0900
committerRalf Baechle <ralf@linux-mips.org>2010-08-05 13:26:05 +0100
commitb3b3c176d9150af542d9ba5e5b292d233883ff85 (patch)
tree073dba3fa8518483c1eba7fc07cf7c1baf57ecef
parentf5c1ca77a3b2f9b424c4f39bd71143d0ac308924 (diff)
downloadlinux-b3b3c176d9150af542d9ba5e5b292d233883ff85.tar.gz
linux-b3b3c176d9150af542d9ba5e5b292d233883ff85.tar.bz2
linux-b3b3c176d9150af542d9ba5e5b292d233883ff85.zip
MIPS: MTX-1: cleanup and comments
Add some comments about mtx1_pci_idsel() and remove a dead block of old code. Signed-off-by: Bruno Randolf <br1@einfach.org> To: linux-mips@linux-mips.org To: manuel.lauss@googlemail.com Cc: florian@openwrt.org Patchwork: https://patchwork.linux-mips.org/patch/1449/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
-rw-r--r--arch/mips/alchemy/mtx-1/board_setup.c12
1 files changed, 4 insertions, 8 deletions
diff --git a/arch/mips/alchemy/mtx-1/board_setup.c b/arch/mips/alchemy/mtx-1/board_setup.c
index def1a75d7561..ff3697387b89 100644
--- a/arch/mips/alchemy/mtx-1/board_setup.c
+++ b/arch/mips/alchemy/mtx-1/board_setup.c
@@ -108,14 +108,10 @@ void __init board_setup(void)
int
mtx1_pci_idsel(unsigned int devsel, int assert)
{
-#define MTX_IDSEL_ONLY_0_AND_3 0
-#if MTX_IDSEL_ONLY_0_AND_3
- if (devsel != 0 && devsel != 3) {
- printk(KERN_ERR "*** not 0 or 3\n");
- return 0;
- }
-#endif
-
+ /* This function is only necessary to support a proprietary Cardbus
+ * adapter on the mtx-1 "singleboard" variant. It triggers a custom
+ * logic chip connected to EXT_IO3 (GPIO1) to suppress IDSEL signals.
+ */
if (assert && devsel != 0)
/* Suppress signal to Cardbus */
alchemy_gpio_set_value(1, 0); /* set EXT_IO3 OFF */