summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWolfram Sang <w.sang@pengutronix.de>2009-07-20 10:58:59 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2009-09-15 10:17:16 -0700
commitb4b3d7bbe1e1d924dc5f3b48b6c06977aee2d494 (patch)
treea63a04b5a6f24d4ba80c7af4d25379d505a8844f
parentd598de02187e4de89595537f69dffe8334f9a066 (diff)
downloadlinux-b4b3d7bbe1e1d924dc5f3b48b6c06977aee2d494.tar.gz
linux-b4b3d7bbe1e1d924dc5f3b48b6c06977aee2d494.tar.bz2
linux-b4b3d7bbe1e1d924dc5f3b48b6c06977aee2d494.zip
pcmcia: fix incorrect argument order to list_add_tail()
Commit a56bc69a182f501582557af7fad5bc882b1c856c fixed a wrong usage of list_add_tail() within store_new_id() for PCI. Port the fix to PCMCIA, which adapted this function from PCI. Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Cc: Dominik Brodowski <linux@dominikbrodowski.net> Cc: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/pcmcia/ds.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c
index 304ff6d5cf3b..9f300d3cb125 100644
--- a/drivers/pcmcia/ds.c
+++ b/drivers/pcmcia/ds.c
@@ -236,7 +236,6 @@ pcmcia_store_new_id(struct device_driver *driver, const char *buf, size_t count)
if (!dynid)
return -ENOMEM;
- INIT_LIST_HEAD(&dynid->node);
dynid->id.match_flags = match_flags;
dynid->id.manf_id = manf_id;
dynid->id.card_id = card_id;
@@ -246,7 +245,7 @@ pcmcia_store_new_id(struct device_driver *driver, const char *buf, size_t count)
memcpy(dynid->id.prod_id_hash, prod_id_hash, sizeof(__u32) * 4);
spin_lock(&pdrv->dynids.lock);
- list_add_tail(&pdrv->dynids.list, &dynid->node);
+ list_add_tail(&dynid->node, &pdrv->dynids.list);
spin_unlock(&pdrv->dynids.lock);
if (get_driver(&pdrv->drv)) {