diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2012-06-13 16:56:31 +0200 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2012-07-20 08:58:57 +0100 |
| commit | b5ee8f2802c559fccb177c0a117f5cd56c1049cc (patch) | |
| tree | 6070c23dd5e23bc02bae19b3d74c8ad88d739cdb | |
| parent | a752359f2b0a291c5f229e883842e4b30c698387 (diff) | |
| download | linux-b5ee8f2802c559fccb177c0a117f5cd56c1049cc.tar.gz linux-b5ee8f2802c559fccb177c0a117f5cd56c1049cc.tar.bz2 linux-b5ee8f2802c559fccb177c0a117f5cd56c1049cc.zip | |
[SCSI] virtio-scsi: unlock during kick
Separate virtqueue_kick_prepare from virtqueue_notify, so that the
expensive vmexit is done without holding the lock.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
| -rw-r--r-- | drivers/scsi/virtio_scsi.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 1b3843117268..b0ad5aa6b552 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi/virtio_scsi.c @@ -264,9 +264,11 @@ static int virtscsi_kick_cmd(struct virtio_scsi *vscsi, struct virtqueue *vq, ret = virtqueue_add_buf(vq, vscsi->sg, out_num, in_num, cmd, gfp); if (ret >= 0) - virtqueue_kick(vq); + ret = virtqueue_kick_prepare(vq); spin_unlock_irqrestore(&vscsi->vq_lock, flags); + if (ret > 0) + virtqueue_notify(vq); return ret; } |