diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2021-08-21 12:37:24 +0200 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2021-09-14 12:02:10 +0100 |
| commit | bbcf40816b547b3c37af49168950491d20d81ce1 (patch) | |
| tree | b5e1a16abc788f88d50af3239180e835c3b71a67 | |
| parent | 9909a395e9807aa79145c9289d0c13d0133359a2 (diff) | |
| download | linux-bbcf40816b547b3c37af49168950491d20d81ce1.tar.gz linux-bbcf40816b547b3c37af49168950491d20d81ce1.tar.bz2 linux-bbcf40816b547b3c37af49168950491d20d81ce1.zip | |
iio: adc128s052: Fix the error handling path of 'adc128_probe()'
A successful 'regulator_enable()' call should be balanced by a
corresponding 'regulator_disable()' call in the error handling path of the
probe, as already done in the remove function.
Update the error handling path accordingly.
Fixes: 913b86468674 ("iio: adc: Add TI ADC128S052")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Link: https://lore.kernel.org/r/85189f1cfcf6f5f7b42d8730966f2a074b07b5f5.1629542160.git.christophe.jaillet@wanadoo.fr
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
| -rw-r--r-- | drivers/iio/adc/ti-adc128s052.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c index 3143f35a6509..83c1ae07b3e9 100644 --- a/drivers/iio/adc/ti-adc128s052.c +++ b/drivers/iio/adc/ti-adc128s052.c @@ -171,7 +171,13 @@ static int adc128_probe(struct spi_device *spi) mutex_init(&adc->lock); ret = iio_device_register(indio_dev); + if (ret) + goto err_disable_regulator; + return 0; + +err_disable_regulator: + regulator_disable(adc->reg); return ret; } |