summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrian Norris <computersforpeace@gmail.com>2015-12-09 14:50:26 -0800
committerShuah Khan <shuahkh@osg.samsung.com>2016-01-07 13:43:28 -0700
commitbe4a1326d12cce8df1f57017bf4112eaab437a38 (patch)
treec271e4c6942f46a387efabcdf3d003c9a80b5084
parent47e0bbb7fa985a0f1b5794a8653fae4f8f49de77 (diff)
downloadlinux-be4a1326d12cce8df1f57017bf4112eaab437a38.tar.gz
linux-be4a1326d12cce8df1f57017bf4112eaab437a38.tar.bz2
linux-be4a1326d12cce8df1f57017bf4112eaab437a38.zip
test: firmware_class: use kstrndup() where appropriate
We're essentially just doing an open-coded kstrndup(). The only differences are with what happens after the first '\0' character, but request_firmware() doesn't care about that. Suggested-by: Kees Cook <keescook@chromium.org> Signed-off-by: Brian Norris <computersforpeace@gmail.com> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
-rw-r--r--lib/test_firmware.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/test_firmware.c b/lib/test_firmware.c
index 841191061816..690b9c35a274 100644
--- a/lib/test_firmware.c
+++ b/lib/test_firmware.c
@@ -54,10 +54,9 @@ static ssize_t trigger_request_store(struct device *dev,
int rc;
char *name;
- name = kzalloc(count + 1, GFP_KERNEL);
+ name = kstrndup(buf, count, GFP_KERNEL);
if (!name)
return -ENOSPC;
- memcpy(name, buf, count);
pr_info("loading '%s'\n", name);