diff options
| author | Rasmus Villemoes <linux@rasmusvillemoes.dk> | 2019-09-19 11:17:27 +0200 |
|---|---|---|
| committer | Thierry Reding <thierry.reding@gmail.com> | 2020-06-02 15:50:52 +0200 |
| commit | cad0f2960675261584c14e8f0026cd67c60f4864 (patch) | |
| tree | ac579132529a0c2e1ec5f374edbd412f012788b2 | |
| parent | ca162ce98110b98e7d97b7157328d34dcfdd40a9 (diff) | |
| download | linux-cad0f2960675261584c14e8f0026cd67c60f4864.tar.gz linux-cad0f2960675261584c14e8f0026cd67c60f4864.tar.bz2 linux-cad0f2960675261584c14e8f0026cd67c60f4864.zip | |
pwm: rockchip: Simplify rockchip_pwm_get_state()
The way state->enabled is computed is rather convoluted and hard to
read - both branches of the if() actually do the exact same thing. So
remove the if(), and further simplify "<boolean condition> ? true :
false" to "<boolean condition>".
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
| -rw-r--r-- | drivers/pwm/pwm-rockchip.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c index 73352e6fbccb..eb8c9cb645a6 100644 --- a/drivers/pwm/pwm-rockchip.c +++ b/drivers/pwm/pwm-rockchip.c @@ -83,12 +83,7 @@ static void rockchip_pwm_get_state(struct pwm_chip *chip, state->duty_cycle = DIV_ROUND_CLOSEST_ULL(tmp, clk_rate); val = readl_relaxed(pc->base + pc->data->regs.ctrl); - if (pc->data->supports_polarity) - state->enabled = ((val & enable_conf) != enable_conf) ? - false : true; - else - state->enabled = ((val & enable_conf) == enable_conf) ? - true : false; + state->enabled = (val & enable_conf) == enable_conf; if (pc->data->supports_polarity && !(val & PWM_DUTY_POSITIVE)) state->polarity = PWM_POLARITY_INVERSED; |