diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2024-04-08 09:34:24 +0200 |
|---|---|---|
| committer | Jean Delvare <jdelvare@suse.de> | 2024-04-08 09:34:24 +0200 |
| commit | cf770af5645a41a753c55a053fa1237105b0964a (patch) | |
| tree | 09da32eeebf694e38afdbe1b2f60dec8cea15600 | |
| parent | e8f897f4afef0031fe618a8e94127a0934896aba (diff) | |
| download | linux-cf770af5645a41a753c55a053fa1237105b0964a.tar.gz linux-cf770af5645a41a753c55a053fa1237105b0964a.tar.bz2 linux-cf770af5645a41a753c55a053fa1237105b0964a.zip | |
firmware: dmi-id: add a release callback function
dmi_class uses kfree() as the .release function, but that now causes
a warning with clang-16 as it violates control flow integrity (KCFI)
rules:
drivers/firmware/dmi-id.c:174:17: error: cast from 'void (*)(const void *)' to 'void (*)(struct device *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
174 | .dev_release = (void(*)(struct device *)) kfree,
Add an explicit function to call kfree() instead.
Fixes: 4f5c791a850e ("DMI-based module autoloading")
Link: https://lore.kernel.org/lkml/20240213100238.456912-1-arnd@kernel.org/
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jean Delvare <jdelvare@suse.de>
| -rw-r--r-- | drivers/firmware/dmi-id.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/firmware/dmi-id.c b/drivers/firmware/dmi-id.c index 5f3a3e913d28..d19c78a78ae3 100644 --- a/drivers/firmware/dmi-id.c +++ b/drivers/firmware/dmi-id.c @@ -169,9 +169,14 @@ static int dmi_dev_uevent(const struct device *dev, struct kobj_uevent_env *env) return 0; } +static void dmi_dev_release(struct device *dev) +{ + kfree(dev); +} + static struct class dmi_class = { .name = "dmi", - .dev_release = (void(*)(struct device *)) kfree, + .dev_release = dmi_dev_release, .dev_uevent = dmi_dev_uevent, }; |